-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display revisions when generating a badge for a multi-source application #17986
Comments
if approved, i am willing to provide pr. |
This seems like a bit of a UX challenge. What would the presentation of 2 revisions look like? Of 5? |
Line 1 in 9a8f3cd
is cropping data when returning multiline revision strings showing only the first one. any design guide / any suggestion to handle this kinda issue? FYI: if revision strings are returned in a single line string, it can be visible adding width param in badge-url e.g. &width=500
|
ArgoCD versions 2.10 and below have reached EOL. Can you upgrade and tell us if the issue is still present, please? |
Hi! Yes, it is present in the greatest latest. Maybe next time it'd be nice if you could just a run a quick check yourself, it'd just a matter of reading the bug report and clicking on the code segment linked in the description which points to master. I understand that doing auto-triage is useful as there's a big backlog of issues, but it's also a bit annoying for reporters. |
While I'd generally agree with you, I'm going through ~1600 bugs manually, so can't check every one of them. That's where I rely on the community help. Please, be understanding. |
Any update on this? I don’t think it needs to be overly complex. For most people, it would be enough to show the revision in a badge for the first defined source in a multiple-source setup. For example, when using Helm with external values, I’m not really interested in the revision of the values, but I’m definitely interested in the It follows the same principle as how you want your application to be previewed in the UI. If you define external values as the first source, the application will be displayed as a Git repository. If you define the chart first, it will be shown as a Helm release. |
…ource application Signed-off-by: fpetr <[email protected]>
Checklist:
argocd version
.Describe the bug
badge.go does not take into account multi-source applications when determining the revision to display on a badge. It only extracts the value from
app.Status.OperationState.SyncResult.Revision
, leavingapp.Status.OperationState.SyncResult.Revisions
behind.Example multi-source application object dumped via the API:
To Reproduce
Crate a multi-source application and generate a the badge passing
revision=true
. No revision is added.Expected behavior
Revisions from sources are added to the badge.
Screenshots
n/a
Version
v2.10.7
Logs
n/a
The text was updated successfully, but these errors were encountered: