remove unwanted updating of source-position in app set command (#18887)

ishitasequeira · web-flow · commit 9a8f3cd6b00d · 2024-07-02T17:12:10.000Z
Signed-off-by: ishitasequeira &lt;ishiseq29@gmail.com&gt;
diff --git a/cmd/argocd/commands/app.go b/cmd/argocd/commands/app.go
@@ -776,8 +776,6 @@ func NewApplicationSetCommand(clientOpts *argocdclient.ClientOptions) *cobra.Com
 				}
 			}
 
-			// sourcePosition startes with 1, thus, it needs to be decreased by 1 to find the correct index in the list of sources
-			sourcePosition = sourcePosition - 1
 			visited := cmdutil.SetAppSpecOptions(c.Flags(), &app.Spec, &appOpts, sourcePosition)
 			if visited == 0 {
 				log.Error("Please set at least one option to update")

Original file line number	Diff line number	Diff line change
`@@ -776,8 +776,6 @@ func NewApplicationSetCommand(clientOpts argocdclient.ClientOptions) cobra.Com`
`776`	`776`	`}`
`777`	`777`	`}`
`778`	`778`
`779`		`- // sourcePosition startes with 1, thus, it needs to be decreased by 1 to find the correct index in the list of sources`
`780`		`- sourcePosition = sourcePosition - 1`
`781`	`779`	`visited := cmdutil.SetAppSpecOptions(c.Flags(), &app.Spec, &appOpts, sourcePosition)`
`782`	`780`	`if visited == 0 {`
`783`	`781`	`log.Error("Please set at least one option to update")`