Skip to content

Alternate color of resources in sync panel #18495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gm42 opened this issue Jun 4, 2024 · 3 comments
Open

Alternate color of resources in sync panel #18495

gm42 opened this issue Jun 4, 2024 · 3 comments
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request type:enhancement

Comments

@gm42
Copy link

gm42 commented Jun 4, 2024

Summary

The individual row for each resource in the sync panel could sport an alternating different color.

Motivation

When dealing with applications with a large number of resources it can be dangerous to tick/untick the checkbox of a specific row without a visual aid on making sure that the correct row is being clicked. I do not see this specifically as an a11y improvement but along the lines of similar techniques used in tabular data / spreadsheets.

Proposal

I am already using this custom user style with great results:

div.application-sync-panel__resource:nth-of-type(odd) {
    background: #e0e0e0;
}

This is how it looks like:
image

Detail of the right sync panel:
image

@gm42 gm42 added the enhancement New feature or request label Jun 4, 2024
@agaudreault agaudreault added the component:ui User interfaces bugs and enhancements label Jun 21, 2024
@johnli-developer
Copy link

I will work on this

@christianh814
Copy link
Member

+1 I like this.

@todaywasawesome
Copy link
Contributor

Let's bring this up in the next contributor's meeting.

pasha-codefresh pushed a commit that referenced this issue Oct 10, 2024
* add Alternate color of resources in sync panel

Co-authored-by: Xu Yan <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
Signed-off-by: Xu, Yan <[email protected]>

* format code

Signed-off-by: Xu, Yan <[email protected]>

* update style based on maintainer's feedback

Signed-off-by: Jessie Teng <[email protected]>

* Add these styles to prevent overflow

Signed-off-by: Xu, Yan <[email protected]>

* add style base on maintainer feedback

Signed-off-by: Xu, Yan <[email protected]>

---------

Signed-off-by: Xu, Yan <[email protected]>
Signed-off-by: Jessie Teng <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
ali-hamza-noor pushed a commit to ali-hamza-noor/argo-cd that referenced this issue Oct 10, 2024
…rgoproj#19250)

* add Alternate color of resources in sync panel

Co-authored-by: Xu Yan <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
Signed-off-by: Xu, Yan <[email protected]>

* format code

Signed-off-by: Xu, Yan <[email protected]>

* update style based on maintainer's feedback

Signed-off-by: Jessie Teng <[email protected]>

* Add these styles to prevent overflow

Signed-off-by: Xu, Yan <[email protected]>

* add style base on maintainer feedback

Signed-off-by: Xu, Yan <[email protected]>

---------

Signed-off-by: Xu, Yan <[email protected]>
Signed-off-by: Jessie Teng <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
Signed-off-by: alnoor <[email protected]>
austin5219 pushed a commit to austin5219/argo-cd that referenced this issue Oct 16, 2024
…rgoproj#19250)

* add Alternate color of resources in sync panel

Co-authored-by: Xu Yan <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
Signed-off-by: Xu, Yan <[email protected]>

* format code

Signed-off-by: Xu, Yan <[email protected]>

* update style based on maintainer's feedback

Signed-off-by: Jessie Teng <[email protected]>

* Add these styles to prevent overflow

Signed-off-by: Xu, Yan <[email protected]>

* add style base on maintainer feedback

Signed-off-by: Xu, Yan <[email protected]>

---------

Signed-off-by: Xu, Yan <[email protected]>
Signed-off-by: Jessie Teng <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
Signed-off-by: austin5219 <[email protected]>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this issue Dec 4, 2024
…rgoproj#19250)

* add Alternate color of resources in sync panel

Co-authored-by: Xu Yan <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
Signed-off-by: Xu, Yan <[email protected]>

* format code

Signed-off-by: Xu, Yan <[email protected]>

* update style based on maintainer's feedback

Signed-off-by: Jessie Teng <[email protected]>

* Add these styles to prevent overflow

Signed-off-by: Xu, Yan <[email protected]>

* add style base on maintainer feedback

Signed-off-by: Xu, Yan <[email protected]>

---------

Signed-off-by: Xu, Yan <[email protected]>
Signed-off-by: Jessie Teng <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request type:enhancement
Projects
None yet
Development

No branches or pull requests

6 participants