Change `repository.credentials` in argocd-cm to declerative repositories for ArgoCD 3.0.0

[philipsens]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd-autopilot version.

Describe the bug

Since ArgoCD version 3.0.0 is it not possible to use the legacy repo config.

This results in the applications not being able to be synced, because the repository is unknown.

To Reproduce

Use the current version of ArgoCD Autopilot and use it to bootstrap the (stable) 3.0.0 version of ArgoCD.

Expected behavior

The new declarative setup for repositories should be used.

Screenshots

Version

❯ argocd-autopilot version
v0.4.19

Logs

ComparisonError
Failed to load target state: failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = failed to list refs: authentication required: Repository not found.

[paulhankarius]

Experiencing the same issue here.
On 3.0.3, I had to add repo cred manually
argocd repo add https://github.com/ORG_NAME/argocd-autopilot --username <username> --password <password>

[philipsens]

Currently, Autopilot defines credentials for the whole of GitHub (for example), not just a single repository. So a more fitting solution could be to use a declarative repository credentials template. Like so:

apiVersion: v1
kind: Secret
metadata:
  name: github-https-creds
  namespace: argocd
  labels:
    argocd.argoproj.io/secret-type: repo-creds
stringData:
  password: 
  type: git
  url: https://github.com
  username: 
type: Opaque

Source: https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#repository-credentials

[orange723]

same issues

[orange723]

I crate secret

example

apiVersion: v1
kind: Secret
metadata:
  name: github-https-creds
  namespace: argocd
  labels:
    argocd.argoproj.io/secret-type: repo-creds
stringData:
  password: "MyPAT"
  type: git
  url: https://github.com/owner/repo
  username: username
type: Opaque

and argocd is sync

thanks

[aronreisx]

Currently, Autopilot defines credentials for the whole of GitHub (for example), not just a single repository. So a more fitting solution could be to use a declarative repository credentials template. Like so:

apiVersion: v1
kind: Secret
metadata:
name: github-https-creds
namespace: argocd
labels:
argocd.argoproj.io/secret-type: repo-creds
stringData:
password:
type: git
url: https://github.com
username:
type: Opaque
Source: https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#repository-credentials

I encountered the same issue and ended up using a similar solution—declaring the secret and referencing it in bootstrap/argo-cd/kustomization.yaml.

However, I'm not comfortable committing sensitive data to the repository. I think a better alternative would be to use KubeFactory to apply the credentials secret dynamically whenever repo bootstrap --recover or repo bootstrap is invoked.

I'd also be interested to hear the maintainers' perspective on this approach.

[aronreisx]

I have created a pull request to address the issue: #674

More details about the solution can be found on the pull request description, but it's worth to mention all the pipelines steps have succeed, however the docker scan step have failed due to existing vulnerabilities.

I have successfully ran locally using the following commands:

# Build the binary and copy to /usr/local/bin/
sudo -E make local

# Bootstrap ArgoCD
argocd-autopilot-dev repo bootstrap --repo https://github.com/aronreisx/argocd-bootstrap-test.git

To ensure it able to be recoved, I used:

argocd-autopilot-dev repo bootstrap --recover --repo https://github.com/aronreisx/argocd-bootstrap-test.git

[aronreisx]

Update: The pipeline is green now after bumping the two vulnerable dependencies that were crashing it.