Skip to content

Refactor/config load #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Refactor/config load #178

merged 11 commits into from
Mar 7, 2024

Conversation

QizhengMo
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@9d74403). Click here to learn what that means.

Files Patch % Lines
...config/impl/ServiceCollectConfigurableHandler.java 92.00% 2 Missing ⚠️
...ler/config/AgentRemoteConfigurationController.java 89.47% 2 Missing ⚠️
.../impl/ApplicationInstancesConfigurableHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #178   +/-   ##
======================================
  Coverage        ?   3.96%           
  Complexity      ?      46           
======================================
  Files           ?      88           
  Lines           ?    3579           
  Branches        ?     429           
======================================
  Hits            ?     142           
  Misses          ?    3427           
  Partials        ?      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QizhengMo QizhengMo requested review from coryhh and binyu1005 March 6, 2024 11:00
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@QizhengMo QizhengMo requested a review from wildeslam March 6, 2024 11:17
@QizhengMo QizhengMo merged commit 46e4a76 into main Mar 7, 2024
@QizhengMo QizhengMo deleted the refactor/config-load branch March 7, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants