Skip to content

feat: add ServiceCollectConfiguration #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024
Merged

feat: add ServiceCollectConfiguration #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
284ea0d
feat: add ServiceCollectConfiguration
Jan 24, 2024
1501a6f
Merge branch 'main' into feat/addServiceCollectConfiguration
coryhh Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...storage-web-api/src/main/java/com/arextest/storage/service/config/ApplicationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import static com.arextest.storage.cache.CacheKeyUtils.DASH;
import static com.arextest.storage.cache.CacheKeyUtils.SERVICE_MAPPINGS_PREFIX;

import com.arextest.common.cache.CacheProvider;
import com.arextest.config.model.dto.StatusType;
import com.arextest.config.model.dto.application.ApplicationConfiguration;
Expand All @@ -16,6 +17,7 @@
import com.arextest.storage.cache.CacheKeyUtils;
import com.arextest.storage.repository.ProviderNames;
import com.arextest.storage.service.MockSourceEditionService;
import com.arextest.storage.service.config.impl.ServiceCollectConfigurableHandler;
import com.arextest.storage.utils.RandomUtils;
import com.fasterxml.jackson.databind.ObjectMapper;
import java.util.Arrays;
Expand Down Expand Up @@ -57,6 +59,9 @@ public class ApplicationService {
@Resource
private ApplicationOperationConfigurationRepositoryImpl serviceOperationRepository;

@Resource
private ServiceCollectConfigurableHandler serviceCollectConfigurableHandler;

public AddApplicationResponse addApplication(AddApplicationRequest request) {
AddApplicationResponse response = new AddApplicationResponse();

Expand All @@ -80,6 +85,7 @@ public AddApplicationResponse addApplication(AddApplicationRequest request) {
applicationConfiguration.setAppId(appId);

boolean success = applicationConfigurationRepository.insert(applicationConfiguration);
serviceCollectConfigurableHandler.createFromGlobalDefault(appId);
response.setAppId(appId);
response.setSuccess(success);
return response;
Expand Down
4 changes: 1 addition & 3 deletions ...main/java/com/arextest/storage/service/config/impl/ServiceCollectConfigurableHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import com.arextest.config.model.dto.record.ServiceCollectConfiguration;
import com.arextest.config.repository.ConfigRepositoryProvider;
import com.arextest.storage.service.config.AbstractConfigurableHandler;
import com.google.common.collect.Sets;
import com.google.common.collect.Sets.SetView;
import java.util.Collections;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -36,7 +34,7 @@ private ServiceCollectConfigurableHandler(
}

@Override
protected List<ServiceCollectConfiguration> createFromGlobalDefault(String appId) {
public List<ServiceCollectConfiguration> createFromGlobalDefault(String appId) {
ServiceCollectConfiguration serviceCollectConfiguration = new ServiceCollectConfiguration();
serviceCollectConfiguration.setAppId(appId);
serviceCollectConfiguration.setSampleRate(globalDefaultConfiguration.getSampleRate());
Expand Down