Skip to content

feat: delayed invalid record case #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

feat: delayed invalid record case #135

merged 2 commits into from
Dec 20, 2023

Conversation

sljoyy
Copy link
Collaborator

@sljoyy sljoyy commented Dec 20, 2023 •
edited
Loading

  • When recording or replaying, the data needs to be cleaned up or marked invalid due to incomplete recording data.
  • Since saving data is asynchronous, a delay is added to ensure that the cleanup is successful.

@sljoyy sljoyy requested review from mr3, coryhh and QizhengMo December 20, 2023 02:27
QizhengMo
QizhengMo previously approved these changes Dec 20, 2023
View reviewed changes
@sljoyy sljoyy force-pushed the feat/delay-invalid branch from 6a20556 to de7f9c9 Compare December 20, 2023 06:32
@sljoyy sljoyy requested review from QizhengMo and mr3 December 20, 2023 06:34
@sljoyy sljoyy force-pushed the feat/delay-invalid branch from de7f9c9 to d342319 Compare December 20, 2023 08:23
@sljoyy sljoyy requested a review from mr3 December 20, 2023 08:27
@sljoyy sljoyy force-pushed the feat/delay-invalid branch from d342319 to 7dd2a1a Compare December 20, 2023 11:38
@sljoyy sljoyy requested a review from srotony December 20, 2023 11:40
mr3
mr3 previously approved these changes Dec 20, 2023
View reviewed changes
@sljoyy sljoyy force-pushed the feat/delay-invalid branch 2 times, most recently from ed064d9 to 5e16cda Compare December 20, 2023 12:00
@sljoyy sljoyy force-pushed the feat/delay-invalid branch from 5e16cda to 11ebedd Compare December 20, 2023 12:02
@sljoyy sljoyy requested a review from mr3 December 20, 2023 12:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sljoyy sljoyy merged commit db437c1 into arextest:main Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr3 mr3 mr3 approved these changes

@QizhengMo QizhengMo QizhengMo approved these changes

@coryhh coryhh Awaiting requested review from coryhh

@srotony srotony Awaiting requested review from srotony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sljoyy @mr3 @QizhengMo