Skip to content

feat(misconf): convert AWS managed policy to document #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Apr 18, 2025

Description

This PR adds support for converting AWS managed policies by their ARN or name into full IAM documents. For now, the conversion is only implemented for AmazonS3FullAccess policies as part of the AVD-AWS-0345 enhancement. No changes are required on the check side as it already works with IAM documents. An alternative solution is to export ARN policies to Rego and convert them in checks.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review April 18, 2025 14:28
@nikpivkin nikpivkin requested a review from simar7 as a code owner April 18, 2025 14:28
@simar7 simar7 added this pull request to the merge queue Apr 23, 2025
Merged via the queue into aquasecurity:main with commit 7abf5f0 Apr 23, 2025
13 checks passed
@itaysk
Copy link
Contributor

itaysk commented Apr 23, 2025

can you please update the documentation accordingly?

@nikpivkin nikpivkin deleted the aws-managed-policy branch April 24, 2025 04:36
@nikpivkin
Copy link
Contributor Author

can you please update the documentation accordingly?

Is this necessary? This change does not affect users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(checks): Improve AVD-AWS-0345
3 participants