feat(misconf): add option to pass Rego scanner to IaC scanner #8369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <[email protected]>
nikpivkin
force-pushed
the
feat/rego-scan-opt
branch
from
db15a17 to
711771e
Compare
nikpivkin
force-pushed
the
feat/rego-scan-opt
branch
from
7ce2d8c to
85b7614
Compare
simar7
force-pushed
the
feat/rego-scan-opt
branch
from
0ec5532 to
d593ec9
Compare
simar7
reviewed
Apr 2, 2025
| regoScanner := rego.NewScanner(regoOpts...) | ||
| // note: it is safe to pass nil as fsys, since checks and data files will be loaded | ||
| // from the filesystems passed through the options. | ||
| if err := regoScanner.LoadPolicies(nil); err != nil { |
There was a problem hiding this comment.
While I understand your comment, maybe it's time to refactor this function as passing nil seems a bit clunky. We can do it in a different PR.
simar7
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to pass the Rego scanner to IaC scanners. This gives the ability to initialize the Rego scanner and load checks only once before scanning.
Checklist