Resolve Detection Bugs with Browsers #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…env var to turn off IPC with the CLI. Check for LIB env var before doing GOT detection checks.
seanvaleo
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the check for spaces at end of file looks at the entire path and not the end only.
need an env var to turn off IPC. the use of mq_open (any mq_) causes firefox checks to emit an error. we disable it with a MOZ_ env var.
we need to check the config var for lib checks. we don't check at all. chrome encounters GOT check errors as chromeOS installs its' own handlers for many (all?) libc functions. we'd want to disable GOT checks in a case like chrome.