HACK FIX - Removed dependency on 'packaging.versions' #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packagine.versions is a very convenient way to compare package versions for compatibility support. However, we cannot expect that the Open edX deployment will have `packaging` installed. This commit undos the dependency on `packaging` which was introduced through backporting `django_filters` version checking to handle breaking changes between the versions. Instead we added a crude version parsing function into `figures.filters` and currently only use it for `django_filters` which has the major, minor, and point versions in the usual 'x.y.z' dot delimited numeric format. So this will work for Django Filter but no guarantee for all packages.
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 41 41
Lines 2161 2161
=======================================
Hits 1982 1982
Misses 179 179
Continue to review full report at Codecov.
|
OmarIthawi
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packagine.versions is a very convenient way to compare package versions
for compatibility support. However, we cannot expect that the Open edX
deployment will have
packaginginstalled.This commit undos the dependency on
packagingwhich was introducedthrough backporting
django_filtersversion checking to handle breakingchanges between the versions. Instead we added a crude version parsing
function into
figures.filtersand currently only use it fordjango_filterswhich has the major, minor, and point versions in theusual 'x.y.z' dot delimited numeric format. So this will work for Django
Filter but no guarantee for all packages.