Skip to content

Add success feedback to csv export dialog #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

grozdanowski
Copy link
Contributor

The export CSV dialog didn't give any feedback upon finishing the export. This PR adds that.

Screenshot:

Screenshot 2020-10-08 at 14 07 28

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          41       41           
  Lines        2150     2150           
=======================================
  Hits         1977     1977           
  Misses        173      173           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c20fb...b7dc0c9. Read the comment docs.

Copy link
Contributor

@johnbaldwin johnbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matej!

@johnbaldwin johnbaldwin merged commit 629ec87 into master Oct 8, 2020
@johnbaldwin johnbaldwin deleted the matej-work/csv-export-ui-feedback branch October 8, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants