[WIP] Overall Learner metrics view #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the initial commit so Matej and work on the front end The endpoint is `/figures/api/learner-metrics/` * There is a basic viewset just to exercise the code. The test requires test data to be filled out and tested in the response * UserFilterSet needs to be updated or an alternate filter set needs to be used in order to provide more filtering, in particular * Show only users who have enrollments * Show only users who do not have enrollments * Show only users who have completed * Show only users who have not completed * List serializers need to be added to prefetch data to improve API performance * test_learner_metrics_viewset needs to be completed * Updated the CourseEnrollment mock to provide the `is_enrolled` method
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 91.78% 91.79%
=======================================
Files 41 41
Lines 2131 2133 +2
=======================================
+ Hits 1956 1958 +2
Misses 175 175
Continue to review full report at Codecov.
|
johnbaldwin
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
@grozdanowski I spot tested in Figures devsite. It doesn't break the app, so I'm going to merge it to master and include in Figures 0.3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the frontend work (albeit a bit optimised further) that was done in PR 229. In order to start with a clean slate with the new API endpoint that John has made, I've redone the work and created a new PR.
I've also added search and ordering to the new endpoint.
What's left to do with the endpoint before merging this frontend work:
enrolled_in_course_id=- currently that only works with one course ID. But this frontend requires the ability to filter by more than one course (same as I haphazardly for demo purposes implemented in the previous PR I created). The frontend is set up to delimit the list of course IDs with a comma.Note: the new frontend view can be found on
[domain]/figures/learners-progress-overview/. I have not added that menu item to header menu, so it can be pushed and tested in production.