add tag view for android #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appium/webdriver/common/mobileby.py
Outdated
| @@ -20,5 +20,6 @@ class MobileBy(By): | |||
| IOS_UIAUTOMATION = '-ios uiautomation' | |||
| IOS_CLASS_CHAIN = '-ios class chain' | |||
| ANDROID_UIAUTOMATOR = '-android uiautomator' | |||
| ANDROID_TAGVIEW = '-android viewtag' | |||
appium/webdriver/webdriver.py
Outdated
| @@ -341,6 +341,30 @@ def find_elements_by_android_uiautomator(self, uia_string): | |||
| """ | |||
| return self.find_elements(by=By.ANDROID_UIAUTOMATOR, value=uia_string) | |||
|
|
|||
| def find_element_by_android_viewtag(self, tag_string): | |||
appium/webdriver/webdriver.py
Outdated
| https://developer.android.com/reference/android/view/View | ||
|
|
||
| :Args: | ||
| - tag_string - The element name by tag view in Android |
There was a problem hiding this comment.
The tag name of the view to look for
appium/webdriver/webdriver.py
Outdated
| @@ -341,6 +341,30 @@ def find_elements_by_android_uiautomator(self, uia_string): | |||
| """ | |||
| return self.find_elements(by=By.ANDROID_UIAUTOMATOR, value=uia_string) | |||
|
|
|||
| def find_element_by_android_viewtag(self, tag): | |||
| """Finds element by tag in Android. | |||
There was a problem hiding this comment.
Perhaps, it worth to mentions that such locator only works for Espresso driver
There was a problem hiding this comment.
👍 Yeah, I'm appending find_element_by_android_viewtag section in README. I'll mention the point here as well.
mykola-mokhnach
approved these changes
Aug 8, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
-android viewtagfor Espresso Driver #237