Fix the second argument type for pushFile #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrinivasanTarget
approved these changes
Jan 17, 2018
valfirst
reviewed
Jan 17, 2018
| Object[] values = new Object[] {remotePath, base64Data}; | ||
| String data; | ||
| try { | ||
| data = new String(base64Data, "UTF-8"); |
There was a problem hiding this comment.
import java.nio.charset.StandardCharsets;
...
data = new String(base64Data, StandardCharsets.UTF_8)?
added 2 commits
January 17, 2018 20:40
4 tasks
TikhomirovSergey
added a commit
that referenced
this pull request
Jan 20, 2018
push file. The addition to the #812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Fixes the second argument type for
pushFileendpoint. Appium expects it to be base64-encoded string, but we send array of bytes instead.Types of changes
Details
See appium/appium-xcuitest-driver#605