Skip to content

Fix #704 #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2017
Merged

Fix #704 #705

merged 1 commit into from
Aug 28, 2017

Conversation

SrinivasanTarget
Copy link
Member

Change list

Fix #704 that breaks iOS test execution.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@TikhomirovSergey ping

mykola-mokhnach
mykola-mokhnach approved these changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy fix

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Aug 28, 2017 •
edited
Loading

@SrinivasanTarget @mykola-mokhnach Will merge and publish it today evening (28.08.2017)

@TikhomirovSergey TikhomirovSergey merged commit 6deca60 into appium:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TikhomirovSergey TikhomirovSergey TikhomirovSergey approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
bug iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.0.0: Brokes iOS tests
3 participants
@SrinivasanTarget @TikhomirovSergey @mykola-mokhnach