PR issue fix. #686
Merged
PR issue fix. #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
added a commit
to valfirst/java-client
that referenced
this pull request
Aug 15, 2022
Appium `io.appium.java_client.pagefactory.bys.builder.ByAll` was implemented as an extension of Selenium `org.openqa.selenium.support.pagefactory.ByAll` and introduced a performance improvement: "By All was re-implemented, now it returns the first founded element for single search." (appium#686 on 3 Aug 2017). However Selenium team introduced the same performance fix "SeleniumHQ/selenium@18028ac ByAll.findElement should not not use remaining locators if an element is already found" on 7 Sep 2017. So there is no reason to keep Appium `ByAll`, this commit deprecates it.
4 tasks
valfirst
added a commit
to valfirst/java-client
that referenced
this pull request
Aug 15, 2022
Appium `io.appium.java_client.pagefactory.bys.builder.ByAll` was implemented as an extension of Selenium `org.openqa.selenium.support.pagefactory.ByAll` and introduced a performance improvement: "By All was re-implemented, now it returns the first founded element for single search." (appium#686 on 3 Aug 2017). However Selenium team introduced the same performance fix "SeleniumHQ/selenium@18028ac ByAll.findElement should not not use remaining locators if an element is already found" on 7 Sep 2017. So there is no reason to keep Appium `ByAll`, this commit deprecates it.
valfirst
added a commit
to valfirst/java-client
that referenced
this pull request
Aug 15, 2022
Appium `io.appium.java_client.pagefactory.bys.builder.ByAll` was implemented as an extension of Selenium `org.openqa.selenium.support.pagefactory.ByAll` and introduced a performance improvement: "By All was re-implemented, now it returns the first founded element for single search." (appium#686 on 3 Aug 2017). However Selenium team introduced the same performance fix "SeleniumHQ/selenium@18028ac ByAll.findElement should not not use remaining locators if an element is already found" on 7 Sep 2017. So there is no reason to keep Appium `ByAll`, this commit deprecates it.
valfirst
added a commit
that referenced
this pull request
Aug 15, 2022
Appium `io.appium.java_client.pagefactory.bys.builder.ByAll` was implemented as an extension of Selenium `org.openqa.selenium.support.pagefactory.ByAll` and introduced a performance improvement: "By All was re-implemented, now it returns the first founded element for single search." (#686 on 3 Aug 2017). However Selenium team introduced the same performance fix "SeleniumHQ/selenium@18028ac ByAll.findElement should not not use remaining locators if an element is already found" on 7 Sep 2017. So there is no reason to keep Appium `ByAll`, this commit deprecates it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#680