Skip to content

added getSession api to fetch deviceUDID #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2016
Merged

added getSession api to fetch deviceUDID #403

merged 3 commits into from
Jun 8, 2016

Conversation

saikrishna321
Copy link
Member

Change list

This PR helps users to fetch the sessionDetails.

appium/appium#6550

#215

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Received response


  "status": 0,
  "value": {
    "platform": "LINUX",
    "webStorageEnabled": false,
    "takesScreenshot": true,
    "javascriptEnabled": true,
    "databaseEnabled": false,
    "networkConnectionEnabled": true,
    "locationContextEnabled": false,
    "warnings": {

    },
    "desired": {
      "app": "\/Users\/saikrisv\/git\/java-client\/java-client\/src\/test\/java\/io\/appium\/java_client\/IntentExample.apk",
      "platformName": "Android",
      "deviceName": "Android Emulator"
    },
    "app": "\/Users\/saikrisv\/git\/java-client\/java-client\/src\/test\/java\/io\/appium\/java_client\/IntentExample.apk",
    "platformName": "Android",
    "deviceName": "192.168.65.101:5555",
    "deviceUDID": "192.168.65.101:5555",
    "platformVersion": "5.0",
    "appPackage": "com.prgguru.android",
    "appWaitPackage": "com.prgguru.android",
    "appActivity": "com.prgguru.android.IntentExampleActivity",
    "appWaitActivity": "com.prgguru.android.IntentExampleActivity"
  },
  "sessionId": "0ac42e16-65c3-40ec-bcf0-fae7d9dd9a4a"
}

Sample Code:

java-client/src/test/java/io/appium/java_client/android/GetSessionDetailsTest.java

@saikrishna321
Copy link
Member Author

@TikhomirovSergey @SrinivasanTarget Please review .

@email2vimalraj your welcome to review this.

@SrinivasanTarget SrinivasanTarget added this to the 4.1.0 milestone Jun 6, 2016
}


@Test public void getDeviceUDIDTest() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this test class? Maybe it makes sense to add this method to https://github.com/appium/java-client/blob/master/src/test/java/io/appium/java_client/android/AndroidDriverTest.java. What do you think?

@TikhomirovSergey
Copy link
Contributor

I'm ok. But there is the remark.

@saikrishna321
Copy link
Member Author

Yup, makes sense to move it AndroidDriverTest .. will do that ....

@saikrishna321
Copy link
Member Author

@TikhomirovSergey made changes as suggested .. Thoughts ?

@SrinivasanTarget
Copy link
Member

@saikrishna321 I see AndroidDriverTest is broken. Can you add this line back https://github.com/appium/java-client/pull/403/files#diff-4cea3ff81e0a1323e7aeb653d2e4a366L30. Also squash your commits if possible.

@saikrishna321
Copy link
Member Author

@SrinivasanTarget made the changes, sorry messed locally cant squash..

@email2vimalraj
Copy link
Contributor

@saikrishna321 : I'm fine with the changes.

@TikhomirovSergey
Copy link
Contributor

Ok. I'm merging it soon

@SrinivasanTarget SrinivasanTarget merged commit eb56807 into appium:master Jun 8, 2016
@SrinivasanTarget
Copy link
Member

Merged @saikrishna321

SrinivasanTarget added a commit that referenced this pull request Jul 18, 2016
pfoster-youitv pushed a commit to pfoster-youitv/appium-java-client that referenced this pull request Jul 29, 2016
The bug which has not been caught previously was worked out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants