-
-
Notifications
You must be signed in to change notification settings - Fork 764
added getSession api to fetch deviceUDID #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@TikhomirovSergey @SrinivasanTarget Please review . @email2vimalraj your welcome to review this. |
} | ||
|
||
|
||
@Test public void getDeviceUDIDTest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add this test class? Maybe it makes sense to add this method to https://github.com/appium/java-client/blob/master/src/test/java/io/appium/java_client/android/AndroidDriverTest.java. What do you think?
I'm ok. But there is the remark. |
Yup, makes sense to move it AndroidDriverTest .. will do that .... |
@TikhomirovSergey made changes as suggested .. Thoughts ? |
@saikrishna321 I see AndroidDriverTest is broken. Can you add this line back https://github.com/appium/java-client/pull/403/files#diff-4cea3ff81e0a1323e7aeb653d2e4a366L30. Also squash your commits if possible. |
@SrinivasanTarget made the changes, sorry messed locally cant squash.. |
@saikrishna321 : I'm fine with the changes. |
Ok. I'm merging it soon |
Merged @saikrishna321 |
The bug which has not been caught previously was worked out.
Change list
This PR helps users to fetch the sessionDetails.
appium/appium#6550
#215
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
Received response
Sample Code:
java-client/src/test/java/io/appium/java_client/android/GetSessionDetailsTest.java