-
-
Notifications
You must be signed in to change notification settings - Fork 764
fix: bring back ability to automatically quote desired capabilities on win #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
d56f6b4
to
8a59520
Compare
mykola-mokhnach
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like it
src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java
Outdated
Show resolved
Hide resolved
…n windows systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
Escaped quotes are necessary for starting appium from the command line on windows systems (see http://appium.io/docs/en/writing-running-appium/default-capabilities-arg/).
This capability to automatically quote on windows systems was completely removed with commit #1337. Since #1336 discovered a special case where automatic quote escaping on windows was not possible. That means, that windows users now need to manually escape the JSON such as:
For a normal user this additional escape
"\"platformName\""
is cumbersome and not intuitive at all. It also makes it hard to write java code running on windows and unix/linux systems.From my understanding, the escaping should be done automatically by the java-client. However, this is a breaking change, thus I propose a switch to be able to enable quote escaping. If desired, I could also implement quote escaping as default behaviour with a switch to disable it. But I think this decision should be on your side.
Cheers!