Skip to content

deprecate selendroid #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 27, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@
*
* @return the strategy which defines how to use locators which are described by the
* {@link SelendroidFindBy} annotation
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidFindBy} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Deprecated
LocatorGroupStrategy selendroidAutomation() default LocatorGroupStrategy.CHAIN;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,13 @@
* {@link io.appium.java_client.remote.AutomationName#SELENDROID} automation is used.
* A declared class should not be abstract. Declared class also should be a subclass
* of an annotated class/class which is declared by an annotated field.
*
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link io.appium.java_client.remote.AutomationName#ANDROID_UIAUTOMATOR2} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
* @return a class which extends {@link io.appium.java_client.pagefactory.Widget}
*/
@Deprecated
Class<? extends Widget> selendroid() default Widget.class;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@

/**
* Used to build a complex selendroid locator.
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidBy} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Deprecated
public @interface SelendroidBy {
/**
* It is an id of the target element.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,14 @@
* series of {@link SelendroidBy} tags
* It will then search for all elements that match any criteria. Note that elements
* are not guaranteed to be in document order.
*
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidBy} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Retention(RUNTIME) @Target({FIELD, TYPE})
@Deprecated
public @interface SelendroidFindAll {
/**
* It is a set of {@link SelendroidBy} strategies which may be used to find the target element.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,15 @@
* {@link org.openqa.selenium.support.PageFactory}
* this allows users to quickly and easily create PageObjects.
* using Selendroid UI selectors like, id, name, class name, tag and xpath
*
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidFindBy} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Retention(RUNTIME) @Target({FIELD, TYPE})
@Repeatable(SelendroidFindBySet.class)
@Deprecated
public @interface SelendroidFindBy {
/**
* It is an id of the target element.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,15 @@
/**
* Defines set of chained/possible locators. Each one locator
* should be defined with {@link SelendroidFindAll}
*
* * @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidFindAll} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Target(value = {TYPE, FIELD})
@Retention(value = RUNTIME)
@Deprecated
public @interface SelendroidFindByAllSet {
/**
* @return an array of {@link SelendroidFindAll} which builds a sequence of
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,15 @@
/**
* Defines set of chained/possible locators. Each one locator
* should be defined with {@link SelendroidFindBys}
*
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidFindBys} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Target(value = {TYPE, FIELD})
@Retention(value = RUNTIME)
@Deprecated
public @interface SelendroidFindByChainSet {
/**
* @return an array of {@link SelendroidFindBys} which builds a sequence of
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,15 @@
/**
* Defines set of chained/possible locators. Each one locator
* should be defined with {@link io.appium.java_client.pagefactory.SelendroidFindBy}
*
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidFindBySet} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Target(value = {TYPE, FIELD})
@Retention(value = RUNTIME)
@Deprecated
public @interface SelendroidFindBySet {
/**
* @return an array of {@link io.appium.java_client.pagefactory.SelendroidFindBy} which builds a sequence of
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@
/**
* Used to mark a field on a Page Object to indicate that lookup should
* use a series of {@link SelendroidBy} tags.
*
* @deprecated Selendroid driver is going to be deprecated.
* Use {@link AndroidBy} instead.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Retention(RUNTIME) @Target({FIELD, TYPE})
@Deprecated
public @interface SelendroidFindBys {
/**
* It is a set of {@link SelendroidBy} strategies which build the chain of the searching for the target element.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@ public interface AndroidMobileCapabilityType extends CapabilityType {
*/
String ANDROID_NATURAL_ORIENTATION = "androidNaturalOrientation";

/**
* Selendroid driver is going to be deprecated.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Deprecated
String SELENDROID_PORT = "selendroidPort";

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ public enum AndroidServerFlag implements ServerArgument {
/**
* Local port used for communication with Selendroid. Sample:
* --selendroid-port 8080
* Selendroid driver is going to be deprecated.
* It is recommended to use UIAutomator1 for Android API below 21
* and UIAutomator2 for API >= 21
*/
@Deprecated
SELENDROID_PORT("--selendroid-port"),
/**
* If set, prevents Appium from killing the adb server
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import java.util.List;

@Deprecated
public class DefaultSelendroidWidget extends DefaultStubWidget {

@SelendroidFindBy(linkText = "SELENDROID_SOME_SUB_LOCATOR")
Expand Down