Skip to content

Move Rails router code into ae_page_objects-rails #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dtognazzini opened this issue Oct 4, 2014 · 1 comment
Open

Move Rails router code into ae_page_objects-rails #83

dtognazzini opened this issue Oct 4, 2014 · 1 comment
Labels
enhancement
Milestone
3.0

Comments

@dtognazzini
Copy link
Contributor

Move all of the Rails specific code out of AePageObjects and into an ae_page_objects-rails gem that declares an explicit dependency on Rails.

Use the most recent version of Rails to run integration tests in ae_page_objects.
Test against all supported versions of Rails in ae_page_objects-rails.
@dtognazzini dtognazzini added this to the 3.0 milestone Oct 4, 2014
@dtognazzini dtognazzini mentioned this issue Oct 13, 2014
Closed
@dtognazzini dtognazzini removed this from the 3.0 milestone May 8, 2015
dtognazzini pushed a commit that referenced this issue May 12, 2016
Simplify testing combinatorics
58fa04f 
This commit changes the testing combinations to the following:

Unit tests - run against various versions of Capybara and Ruby

Integration tests - run against various versions of Capybara and Rails using
the most recent version of Ruby supported by the version of Rails used.

The many versions of Rails are used to verify the ApplicationRouter logic.
This could be simplified by extracting an ae_page_objects-rails gem (#83), reducing
the integration test suite to use a single Rails version.
@dtognazzini dtognazzini mentioned this issue May 12, 2016
Merged
dtognazzini pushed a commit that referenced this issue May 12, 2016
Simplify testing combinatorics
9e246b1 
This commit changes the testing combinations to the following:

Unit tests - run against various versions of Capybara and Ruby

Integration tests - run against various versions of Capybara and Rails using
the most recent version of Ruby supported by the version of Rails used.

The many versions of Rails are used to verify the ApplicationRouter logic.
This could be simplified by extracting an ae_page_objects-rails gem (#83), reducing
the integration test suite to use a single Rails version.
dtognazzini pushed a commit that referenced this issue May 12, 2016
Simplify testing combinatorics
f4b9fe9 
This commit changes the testing combinations to the following:

Unit tests - run against various versions of Capybara and Ruby

Integration tests - run against various versions of Capybara and Rails using
the most recent version of Ruby supported by the version of Rails used.

The many versions of Rails are used to verify the ApplicationRouter logic.
This could be simplified by extracting an ae_page_objects-rails gem (#83), reducing
the integration test suite to use a single Rails version.
dtognazzini pushed a commit that referenced this issue May 13, 2016
Simplify testing combinatorics
42718df 
This commit changes the testing combinations to the following:

Unit tests - run against various versions of Capybara and Ruby

Integration tests - run against various versions of Capybara and Rails using
the most recent version of Ruby supported by the version of Rails used.

The many versions of Rails are used to verify the ApplicationRouter logic.
This could be simplified by extracting an ae_page_objects-rails gem (#83), reducing
the integration test suite to use a single Rails version.

(cherry picked from commit f4b9fe9)
@dtognazzini dtognazzini added this to the 3.0 milestone May 13, 2016
@dtognazzini
Copy link
Contributor Author

#175 moved Rails support to ae_page_objects/rails. Not sure a new gem is warranted. The advantages of moving to a new gem:

  1. ae_page_objects becomes free of any Rails code.
  2. ae_page_objects tests become simpler as only a single version of Rails would be used for integration tests.
  3. ae_page_objects-rails can list explict Rails version dependencies in its gemspec.
  4. ae_page_objects-rails and ae_page_objects can evolve independently of each other.

Disadvantages:

  1. The default ae_page_objects router (BasicRouter) isn't very useful.
  2. AFAICS only Appfolio uses this gem and we mostly use it with Rails projects, so we'd be pulling in both gems in most cases.
  3. Yet another gem to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@dtognazzini