Skip to content

Fix eslint warnings #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Fix eslint warnings #4923

merged 5 commits into from
Apr 17, 2025

Conversation

ValJed
Copy link
Contributor

@ValJed ValJed commented Apr 17, 2025

PRO-7610

Fix all max-len warnings. 🤯

@myovchev myovchev requested review from Copilot and myovchev April 17, 2025 15:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes all eslint max-len warnings by reformatting multi-line comments and adjusting whitespace throughout the codebase. The changes primarily reflow comment blocks, ensuring that no line exceeds the configured maximum length while preserving the original meaning.

  • Rewrapped long comment lines in multiple modules.
  • Applied minor whitespace and formatting corrections to improve code consistency.
  • Updated the changelog with a summary entry.

Reviewed Changes

Copilot reviewed 197 out of 197 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/@apostrophecms/asset/lib/build/external-module-api.js Reflowed comments and adjusted formatting for better readability.
modules/@apostrophecms/asset/index.js Reformatted comment blocks to conform with max-len and fixed minor typos.
modules/@apostrophecms/area/ui/apos/components/*.vue Rewrapped multi-line comments without affecting functionality.
modules/@apostrophecms/any-page-type/index.js Reformatted inline comments to meet length standards.
modules/@apostrophecms/admin-bar/ui/apos/components/*.vue Updated comment formatting for consistency and improved line breaks.
lib/*, index.js, defaults.js, CHANGELOG.md Minor comment reflow and spacing corrections.
Comments suppressed due to low confidence (2)

modules/@apostrophecms/asset/index.js:92

  • The word 'boolen' is misspelled. It should be 'boolean'.
    // - boolen `false`: disable the dev server and HMR.

modules/@apostrophecms/asset/index.js:391

  • The word 'apporpriate' is misspelled. It should be 'appropriate'.
    // It's called only if the module supports dev server and HMR, `hmr` is enabled and if it's apporpriate to start the dev server (development mode, not a task, etc.).

myovchev
myovchev previously approved these changes Apr 17, 2025
@ValJed ValJed merged commit c33df43 into main Apr 17, 2025
9 checks passed
@ValJed ValJed deleted the fix-eslint-warnings branch April 17, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants