Pro 7563 images checkbox #4918
Merged
Pro 7563 images checkbox #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
commented
Apr 14, 2025
| @@ -88,9 +88,6 @@ | |||
| :module-options="moduleOptions" | |||
| :max-reached="maxReached()" | |||
| :is-last-page="isLastPage" | |||
| :options="{ | |||
| hideCheckboxes: !relationshipField | |||
| }" | |||
There was a problem hiding this comment.
Do you see another context where we would like to hide them?
ValJed
commented
Apr 14, 2025
| return {}; | ||
| return { | ||
| hideCheckboxes: false | ||
| }; |
ValJed
commented
Apr 14, 2025
| @@ -265,7 +267,8 @@ export default { | |||
| } | |||
|
|
|||
| .apos-media-manager-display__cell:hover .apos-media-manager-display__checkbox, | |||
| .apos-media-manager-display__cell.apos-is-selected .apos-media-manager-display__checkbox { | |||
| .apos-media-manager-display__cell.apos-is-selected | |||
| .apos-media-manager-display__checkbox { | |||
stuartromanek
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRO-7563
Summary
Gets back images checkboxes, do you see any place where we want to hide them now? Maybe we can just remove the option, or maybe not for BC.
What are the specific steps to test this change?
Checkboxes are visible like before for batch operations.
Cypress 🟢
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: