Pro 7348 #4906
Merged
Pro 7348 #4906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
commented
Apr 8, 2025
| width: max-content; | ||
| max-width: 95vw; | ||
| } | ||
|
|
There was a problem hiding this comment.
Check that toolbar can go beyond parent width (editor) but still shrink to stay visible when window resize.
ValJed
commented
Apr 8, 2025
| .apos-rich-text-insert-menu-label__title, | ||
| .apos-rich-text-insert-menu-label__desc { | ||
| color: var(--a-white); | ||
| } |
There was a problem hiding this comment.
More strict style to be less overridable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/apostrophecms/issue/PRO-7348/rich-text-toolbar-resize-weirdly-when-too-long
https://linear.app/apostrophecms/issue/PRO-7497/the-insert-image-title-becomes-invisible-in-blue-against-a-dark-purple
Summary
max-contentto not be limited to parent width. But also a max-wdith to not go above screen width.What are the specific steps to test this change?
Check tickets.
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: