-
Notifications
You must be signed in to change notification settings - Fork 606
2494 load extra bundles #3689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2494 load extra bundles #3689
Conversation
to be accessible at page load
widgets dependants bundles in req
needed bundles at page load time
and that pages are loading the rights bundles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard would it be to factor this so that you're not relying on "self" to hold a reference to "extraBundles"? I know we can't test es5 builds successfully right now but I am concerned that we already know this is the wrong factoring because there can only be one "self.extraBundles.js" but those files and names are going to be different in the ES5 output. I think we should be getting the namespacing right from the beginning, even if we can't successfully test ES5 right now.
in init instead of in the build task
PRO-2494
Summary
output
method depending on the loaded widgets, load the rights bundlesrenderPageForModule
, check page config to load the right bundles.renderPageForModule
insert computed stylesheet and scripts tagsin the page.What are the specific steps to test this change?
Can be tested in testbed with the branch
pro-2494-bundles
.topic.js
check that alias work. You can try override it in another module for example.topic-widget
on the home page, publish and once logged out, check that the widget bundle is properly loaded.What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements: