log character counts and estimated tokens #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jephuff
force-pushed
the
jeffrey/log-character-length
branch
from
b4dc8d4 to
a925a35
Compare
pubmodmatt
requested changes
May 1, 2025
Jephuff
force-pushed
the
jeffrey/log-character-length
branch
from
a925a35 to
64e9e3d
Compare
pubmodmatt
reviewed
May 6, 2025
| "Tool {} loaded with a character count of {}. Estimated tokens: {}", | ||
| operation_name, | ||
| length, | ||
| length / 4 |
There was a problem hiding this comment.
Why is it dividing by 4 here?
There was a problem hiding this comment.
I think I found it here - "For Claude, a token approximately represents 3.5 English characters". If that's the case, let's get a comment in here explaining the computation.
There was a problem hiding this comment.
Oh yes, 4 was the magical number that everyone seems to say is a reasonable estimate across models. I'll add a comment 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs the character size of each tool as it loads, logs the total character length of all tools and an estimate of the tokens (seems like ~4 characters is roughly a token, but will obviously vary)
Formatting I have right now, definitely open to suggestions to make it better