Skip to content

create container #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 6, 2025
Merged

create container #29

merged 13 commits into from
May 6, 2025

Conversation

nicholascioli
Copy link
Contributor

This PR sets up the infra needed to build containers using Nix and GitHub actions. The container sets the current working directory to /data and thus all configuration should be mounted there within the container.

@nicholascioli nicholascioli self-assigned this Apr 29, 2025
@nicholascioli nicholascioli marked this pull request as ready for review April 30, 2025 20:24
@nicholascioli
Copy link
Contributor Author

The digest calculation is definitely very brittle, but it should work for now until we want multi-arch images.

@nicholascioli
Copy link
Contributor Author

The arm64 build step for the release won't work until the repository goes public. Let me know if you'd like it removed until then so that it doesn't "fail".


config = {
# Make the entrypoint the server
Entrypoint = ["mcp-apollo-server" "-d" "/data"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would a customer configure other options? If they're using the local file options, they'll also need a way to include those in the image. If they're using --uplink, they'd also need a way to set the APOLLO_KEY and APOLLO_GRAPH_REF environment variables.

Adding a README entry like Gary has here would help understand this (presumably environment variables would be set like he has shown there, for example).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a section to the README

@nicholascioli nicholascioli merged commit 06d0bc7 into main May 6, 2025
4 checks passed
@nicholascioli nicholascioli deleted the nc/releases branch May 6, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants