-
Notifications
You must be signed in to change notification settings - Fork 26
create container #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create container #29
Conversation
The digest calculation is definitely very brittle, but it should work for now until we want multi-arch images. |
The arm64 build step for the release won't work until the repository goes public. Let me know if you'd like it removed until then so that it doesn't "fail". |
|
||
config = { | ||
# Make the entrypoint the server | ||
Entrypoint = ["mcp-apollo-server" "-d" "/data"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would a customer configure other options? If they're using the local file options, they'll also need a way to include those in the image. If they're using --uplink
, they'd also need a way to set the APOLLO_KEY
and APOLLO_GRAPH_REF
environment variables.
Adding a README entry like Gary has here would help understand this (presumably environment variables would be set like he has shown there, for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a section to the README
This commit adds support for building container images from nix and a corresponding github action on versioned tags.
This PR sets up the infra needed to build containers using Nix and GitHub actions. The container sets the current working directory to
/data
and thus all configuration should be mounted there within the container.