Parse the comments before the operation as it’s description #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jephuff
force-pushed
the
jeffrey/parse-comment-description
branch
from
066cff9 to
6973b08
Compare
Jephuff
force-pushed
the
jeffrey/parse-comment-description
branch
from
4037e69 to
a147242
Compare
Jephuff
changed the title
pubmodmatt
reviewed
Apr 29, 2025
| match comment_description { | ||
| Some(description) => description, | ||
| None => { | ||
| let mut tree_shaker = TreeShaker::new(graphql_schema, fragment_defs); |
There was a problem hiding this comment.
So if the description is overridden, we're also not providing any type information?
There was a problem hiding this comment.
Right now yes, the comment is treated as a full override.
There was a problem hiding this comment.
Ok for now. We may need to consider how to make this available to the agent. This may be where having the ability to introspect tools comes in.
pubmodmatt
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a secondary description option. If the generated descriptions aren't working for the models, or they are too big users can add a comment before the operation that will be used for the description instead. If no comment exists, it will still do the generated description.
In this example the description would be "this tool will just return a hat for you."