-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix improper syntax with spread operator #9441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
currently the example shows incorrect JS syntax wherein an object is included within an object. this change fixes by using the spread operator `...`. it might be clearer to the user to not include `deleteDog` as a variable, but rather just put it directly into the mock results.
@mongodben: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this @mongodben (and thanks for the ping @jpvajda). I have a feeling the intent here was to just use {
result: { data: deleteDog },
} That might be the cleanest quick change, so we don't have people thinking the spread is necessary for some reason. |
currently the example shows incorrect JS syntax wherein an object is included within an object.
this change fixes by using the spread operator
...
.it might be clearer to the user to not include
deleteDog
as a variable, but rather just put it directly into the mock results.Checklist: