add dataState to useFragment, DataValue type to useSuspenseFragment
#12757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cbc7e3c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
phryneas
commented
Jul 2, 2025
| // valid return value | ||
| data: diff.result === null ? {} : diff.result, | ||
| }), | ||
| } as Cache.DiffResult<TData> // TODO: Remove assertion |
There was a problem hiding this comment.
I moved this assertion one level in - although it needs an any there I believe it's more restrictive that way.
size-limit report 📦
|
phryneas
commented
Jul 2, 2025
| @@ -140,10 +140,14 @@ describe("useFragment", () => { | |||
| } | |||
|
|
|||
| await waitFor(() => { | |||
| expect(getItemTexts()).toEqual(["Item #1", "Item #2", "Item #5"]); | |||
| expect(getItemTexts()).toStrictEqualTyped([ | |||
There was a problem hiding this comment.
While I was at it, I replaced all toEqual in the file with toStrictEqualTyped.
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
❌ Docs preview failedThe preview failed to build. Build ID: 12618a0e434c7eeb7ebea5db ErrorsGeneral: other side closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we had missed these.