Skip to content

Add deprecations and warnings for addTypename and canonizeResults #12743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Jun 27, 2025

Conversation

jerelmiller
Copy link
Member

No description provided.

@jerelmiller jerelmiller requested a review from phryneas June 26, 2025 00:46
Copy link

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: 750d5b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 26, 2025

npm i https://pkg.pr.new/@apollo/client@12743

commit: 750d5b7

@apollo-librarian
Copy link

apollo-librarian bot commented Jun 26, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-3.14 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 627bbee4afb3885e5eed1dce

@jerelmiller jerelmiller marked this pull request as draft June 26, 2025 16:01
Base automatically changed from jerel/deprecations-phase-1 to release-3.14 June 26, 2025 17:26
@jerelmiller jerelmiller force-pushed the jerel/deprecate-canonize-results branch from 5a32600 to 04c4341 Compare June 26, 2025 17:52
Copy link
Contributor

github-actions bot commented Jun 26, 2025

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 41.6 KB (+0.48% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 51.71 KB (+1.57% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 48.44 KB (+1.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 36.86 KB (+1.11% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 33.9 KB (+0.34% 🔺)
import { ApolloProvider } from "@apollo/client/react" 1.26 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production) 1.24 KB (0%)
import { useQuery } from "@apollo/client/react" 10.28 KB (+1.84% 🔺)
import { useQuery } from "@apollo/client/react" (production) 9.14 KB (+1.41% 🔺)
import { useLazyQuery } from "@apollo/client/react" 9.61 KB (+1.35% 🔺)
import { useMutation } from "@apollo/client/react" 3.62 KB (-0.06% 🔽)
import { useMutation } from "@apollo/client/react" (production) 2.84 KB (-0.04% 🔽)
import { useSubscription } from "@apollo/client/react" 4.42 KB (-0.05% 🔽)
import { useSubscription } from "@apollo/client/react" (production) 3.48 KB (-0.03% 🔽)
import { useSuspenseQuery } from "@apollo/client/react" 6.07 KB (+3.12% 🔺)
import { useSuspenseQuery } from "@apollo/client/react" (production) 4.71 KB (+3.31% 🔺)
import { useBackgroundQuery } from "@apollo/client/react" 5.56 KB (+3.36% 🔺)
import { useBackgroundQuery } from "@apollo/client/react" (production) 4.2 KB (+3.99% 🔺)
import { useLoadableQuery } from "@apollo/client/react" 5.64 KB (+3.15% 🔺)
import { useLoadableQuery } from "@apollo/client/react" (production) 4.28 KB (+3.85% 🔺)
import { useReadQuery } from "@apollo/client/react" 3.43 KB (-0.06% 🔽)
import { useReadQuery } from "@apollo/client/react" (production) 3.38 KB (-0.03% 🔽)
import { useFragment } from "@apollo/client/react" 2.55 KB (+8.02% 🔺)
import { useFragment } from "@apollo/client/react" (production) 2.47 KB (+6.98% 🔺)

@jerelmiller jerelmiller marked this pull request as ready for review June 27, 2025 00:17
@@ -206,6 +207,11 @@ function useBackgroundQuery_<
QueryRef<TData, TVariables> | undefined,
UseBackgroundQueryResult<TData, TVariables>,
] {
useWarnRemovedOption(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all of these will be DEV-wrapped with the follow-up PR, but please double-check :)

Copy link
Member Author

@jerelmiller jerelmiller Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed these are all wrapped properly there in #12746

@github-actions github-actions bot added the auto-cleanup 🤖 label Jun 27, 2025
@jerelmiller jerelmiller merged commit 92ad409 into release-3.14 Jun 27, 2025
47 checks passed
@jerelmiller jerelmiller deleted the jerel/deprecate-canonize-results branch June 27, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants