Improve operation type for SetContextLink

[jerelmiller]

This is something I noticed when converting a different app. The operation argument given to the callback in SetContextLink was a GraphQLRequest type which included the context property. This property was always undefined so using it could result in bugs when really you should be using the prevContext argument instead.

This PR adjusts the type to ensure context is not part of the type. This PR also adds the client property from the operation so that its accessible like other links.

[changeset-bot]

🦋 Changeset detected

Latest commit: b787b47

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12742

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client-codemod-migrate-3-to-4@12742

commit: b787b47

[github-actions]

size-limit report 📦

Path	Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS)	42.62 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS)	37.73 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client"	32.55 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production)	26.97 KB (0%)
import { ApolloProvider } from "@apollo/client/react"	5.7 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production)	960 B (0%)
import { useQuery } from "@apollo/client/react"	7.48 KB (0%)
import { useQuery } from "@apollo/client/react" (production)	2.72 KB (0%)
import { useLazyQuery } from "@apollo/client/react"	6.95 KB (0%)
import { useLazyQuery } from "@apollo/client/react" (production)	2.19 KB (0%)
import { useMutation } from "@apollo/client/react"	6.52 KB (0%)
import { useMutation } from "@apollo/client/react" (production)	1.75 KB (0%)
import { useSubscription } from "@apollo/client/react"	6.63 KB (0%)
import { useSubscription } from "@apollo/client/react" (production)	1.86 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react"	8.49 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production)	3.73 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react"	8.22 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production)	3.5 KB (0%)
import { useLoadableQuery } from "@apollo/client/react"	8.54 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production)	3.81 KB (0%)
import { useReadQuery } from "@apollo/client/react"	6.45 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production)	1.68 KB (0%)
import { useFragment } from "@apollo/client/react"	6.49 KB (0%)
import { useFragment } from "@apollo/client/react" (production)	1.74 KB (0%)

[phryneas]

Semi-related - this seems to strip out operationType, which we actually want to preserve.

[phryneas]

See #12748

[jerelmiller]

Really good catch on that. I removed the type cast since the function had an explicit return and now I'm glad I made some noise in this file 😆