Unify and simplify actor and RPC message types

[jerelmiller]

I saw an opportunity to simplify the message types in the app. We use a ton of generics with both the actor and RPC models, but looking through this more, this seemed largely unnecessary because we don't have messages going a bunch of different ways to different things. We largely want to create a single actor/rpc client and use that for messaging in a specific area of the extension.

As a part of this, I decided to simplify the types and remove the need for generics. I've combined the message types together into a single union type that has now moved to the respective files where the implementation lives. This should make it easier to know both where to put the type and avoid confusion on what message type should include new types.

[relativeci]

#747 Bundle Size — 1.5MiB (~-0.01%).

36d9112(current) vs 36cd3bb main#744(baseline)

Warning

Bundle contains 13 duplicate packages – View duplicate packages

Bundle metrics   3 changes 1 improvement

	Current #747	Baseline #744
Initial JS	1.46MiB(~-0.01%)	1.46MiB
Initial CSS	0B	0B
Cache Invalidation	2.19%	97.56%
Chunks	5	5
Assets	12	12
Modules	1210	1210
Duplicate Modules	45	45
Duplicate Code	3.08%(-0.65%)	3.1%
Packages	182	182
Duplicate Packages	10	10

Bundle size by type   1 change 1 improvement

	Current #747	Baseline #744
JS	1.46MiB (~-0.01%)	1.46MiB
IMG	35.85KiB	35.85KiB
HTML	810B	810B
Other	778B	778B

---

Bundle analysis report Branch jerel/simplify-types Project dashboard

[jerelmiller]

Need to move this to the other PR

[phryneas]

Looks like a good improvement :)

[phryneas]

Suggested change

	if (!listeners) {
	listeners = new Set();
	messageListeners.set(name, listeners as Set<(message: Messages) => void>);
	messageListeners.set(
	name,
	listeners as Set<(message: ActorMessage) => void>
	);
	}
	if (!listeners) {
	listeners = new Set();
	messageListeners.set(name, listeners);
	}

Seems the cast is not neccessary here

[jerelmiller]

Good catch!

[alessbell]

Love how this just keeps getting further simplified! 🚀