Updated styles and layout to be compatible with twitter-bootstrap 4 #7
Conversation
|
I have not forgotten this, it's very high up on the prio list, but I have some things I would like to talk to you about first regarding how to customize (e.g. by incorporating the scss step in the Kickstarter or something similar, leveraging the |
|
@DonMartin76 It would be nice to have sass support to let customizing bootstrap variables . Do you have any idea? I'll take a look at kickstarter and portal-env projects to find out possible approaches. |
|
My idea would have been to have a variables file, or simply just use the variables file from Bootstrap, and use the Kickstarter to generate the CSS files. Alternatively, this step could be done startup of the portal API, but for the sake of simplicity, I think the kickstarter can do. Input (in the static configuration) would be the variables file. Output, also in the static configuration, would be the generated CSS file(s). I do not quite know what I am talking about, but it sounds to me it could be a feasible approach. What do you think? |
|
It makes sense. I would implement it in just a couple of days or maybe even sooner. |
|
This will probably not make it into the 1.0 release, but I see it as a 1.1. There are still a couple of open questions we need to assess before we can really take it into the roadmap. Over the next couple of days, I will be dropping the I will open an issue for this to make it more public what we are talking about. |
|
Sure. I'll rebase it whenever the |
|
Branch |
-Wire to portal.com instead of portal.local, otherwise Google locally won't work
armezit
force-pushed
the
twitter-bootstrap-4
branch
from
376ac8e to
d23466b
Compare
|
@DonMartin76 sorry for late response. |
…r-bootstrap-4 # Conflicts: # initial-config/static/content/stylesheets/style.scss
No description provided.