Skip to content

Move configurations to separate markdown file #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2024
Merged

Move configurations to separate markdown file #257

merged 4 commits into from
Mar 13, 2024

Conversation

Siegrift
Copy link
Collaborator

@Siegrift Siegrift commented Mar 11, 2024 •
edited
Loading

Closes #209

  • After this is finalized I need to change the spec links.

@Siegrift Siegrift requested a review from andreogle March 11, 2024 08:40
@Siegrift Siegrift self-assigned this Mar 11, 2024
@Siegrift Siegrift changed the title Readme config Move configurations to separate markdown file Mar 11, 2024
@Siegrift Siegrift mentioned this pull request Mar 11, 2024
Closed
andreogle
andreogle approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@andreogle andreogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to put these in the config/ folders?

@Siegrift
Copy link
Collaborator Author

That might actually be a better place. Good point.

Base automatically changed from set-node-image to main March 13, 2024 19:35
@Siegrift Siegrift force-pushed the readme-config branch 3 times, most recently from 9f04968 to 75f2f03 Compare March 13, 2024 19:47
@Siegrift Siegrift force-pushed the readme-config branch 2 times, most recently from 75f2f03 to a86aca4 Compare March 13, 2024 19:52
@Siegrift Siegrift merged commit 6d2e2d6 into main Mar 13, 2024
@Siegrift Siegrift deleted the readme-config branch March 13, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreogle andreogle andreogle approved these changes

Assignees

@Siegrift Siegrift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move configuration to separate README
2 participants
@Siegrift @andreogle