-
Notifications
You must be signed in to change notification settings - Fork 5
Check which beacons of a beacon set need to be updated #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, as part of this issue we should remove the dummy gas estimation logic because the update transaction can't revert (unless of some rare race condition, but for that there is the generous static gas limit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM (as usual feel free to ignore the nits).
This PR:
Closes #67
Replaces #75 (refactoring this was difficult/it was easier to start from main and re-implement)