Use multicall to fetch dAPI batches #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Oct 30, 2023
| @@ -15,5 +15,6 @@ module.exports = { | |||
| testEnvironment: 'jest-environment-node', | |||
| testMatch: ['**/?(*.)+(feature).[t]s?(x)'], | |||
| testPathIgnorePatterns: ['<rootDir>/.build', '<rootDir>/dist/', '<rootDir>/build/'], | |||
| testTimeout: 15_000, | |||
There was a problem hiding this comment.
This will set 15 seconds timeout for all e2e tests, which should be enough.
| @@ -9,7 +9,7 @@ let env: EnvConfig | undefined; | |||
| export const loadEnv = () => { | |||
| if (env) return env; | |||
|
|
|||
| dotenv.config({ path: join(__dirname, '../.env') }); | |||
| dotenv.config({ path: join(__dirname, '../../.env') }); | |||
There was a problem hiding this comment.
This previously pointed to a non-existent file.
| @@ -0,0 +1,370 @@ | |||
| import * as abi from '@api3/airnode-abi'; | |||
There was a problem hiding this comment.
Siegrift
force-pushed
the
multicall-first-batch
branch
from
76e998a to
72d4571
Compare
vponline
approved these changes
Nov 1, 2023
Siegrift
force-pushed
the
multicall-first-batch
branch
from
72d4571 to
97fa396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46
Rationale
I first wanted to only fix the issue of multicalling the first batch together with the dAPIs count. I wanted to verify that I implemented the functionality correctly, so I wanted to write an e2e test for this (to test the on-chain integration). I followed the setup implemented by @acenolaza here but the contract we used in Airseeker was a bit outdated so I needed to update it. This required using the multicall everywhere.