Skip to content

Try to detect submit tx failures #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Try to detect submit tx failures #248

merged 2 commits into from
Apr 23, 2024

Conversation

Siegrift
Copy link
Collaborator

Closes #243

Rationale

There are other grafana error codes but these are generic and rare. I don't want to do any message parsing so only relying on the error code.

I expect this will help with making the alert more actionable.

@Siegrift Siegrift requested a review from bdrhn9 April 10, 2024 12:59
@Siegrift Siegrift self-assigned this Apr 10, 2024
Base automatically changed from wrap-nonce-in-go to main April 18, 2024 12:54
@Siegrift Siegrift force-pushed the detect-submission-error branch from 43918b3 to ed2fcc4 Compare April 19, 2024 05:35
@Siegrift Siegrift requested a review from bdrhn9 April 19, 2024 05:35
Copy link
Contributor

@bdrhn9 bdrhn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me.

@Siegrift Siegrift force-pushed the detect-submission-error branch from ed2fcc4 to dda05d9 Compare April 23, 2024 07:11
@Siegrift Siegrift merged commit b78eb63 into main Apr 23, 2024
4 checks passed
@Siegrift Siegrift deleted the detect-submission-error branch April 23, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect when update transaction fails with low balance
2 participants