Upgrade contracts3 update #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbenligiray
commented
Jan 1, 2024
| @@ -73,6 +73,10 @@ export const decodeUpdateParameters = (updateParameters: string): DecodedUpdateP | |||
| ['uint256', 'int224', 'uint256'], | |||
| updateParameters | |||
| ); | |||
| // 2 characters for the '0x' preamble + 3 parameters, 32 * 2 hexadecimals for 32 bytes each | |||
| if (updateParameters.length !== 2 + 3 * (32 * 2)) { | |||
There was a problem hiding this comment.
The user (AirseekerRegistry owner) can specify updateParameters of arbitrary length, which is why it is important to check this imo. I check it after the decoding attempt because the error message for it will probably be more descriptive.
There was a problem hiding this comment.
Good point. We should definitely do this.
Siegrift
approved these changes
Jan 1, 2024
Siegrift
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Update deterministic address * Expose data feed ID for local test configuration * Update contract function naming in local test configuration * Improve readability of comment * Check against unexpected update parameters format
Siegrift
added a commit
that referenced
this pull request
Jan 8, 2024
* Update to AirseekerRegistry contract * Properly rename dAPIs to data feeds * Finish contract migration * Fix e2e tests * Handle the case when the data feed is not registered and log warning * Fix wrong function parameter name, edit fixtures * Finish renaming * Rename diagram * Upgrade contracts3 update (#171) * Update deterministic address * Expose data feed ID for local test configuration * Update contract function naming in local test configuration * Improve readability of comment * Check against unexpected update parameters format * Bump api3dao/dapi-management dependency commit * Update tests * Update tests a bit more * Update decode update parameters in local-test folder --------- Co-authored-by: Burak Benligiray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made two changes to AirseekerRegistry:
activeDataFeed()also returndataFeedId. The current airseeker-v2 implementation derives the data feed ID fromdataFeedDetails, which is fine to keep as is.