Skip to content

Support chain configuration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Support chain configuration #11

merged 3 commits into from
Oct 4, 2023

Conversation

Siegrift
Copy link
Collaborator

@Siegrift Siegrift commented Oct 3, 2023

Closes #3

This PR is largely inspired by https://github.com/api3dao/signed-api/tree/main/packages/pusher and some of the code is copied over (will be later moved to commons repo). The chain configuration is a small subset of the old airseeker configuration.

All properties of the configuration should be documented, but there is no implementation yet. Part of the configuration is __Temporary__DapiDataRegistry which is a temporary replacement of DapiDataRegistry contract. I think the current form is usable, but it can be freely changed later (since that section will ultimately be removed).

@Siegrift Siegrift self-assigned this Oct 3, 2023
@Siegrift Siegrift requested review from aquarat and vponline October 3, 2023 16:18
Copy link
Contributor

@vponline vponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I guess the loadConfig function could be something to have in the common repo eventually (it would only need to be changed to accept the config zod schema as an input), along with some of the common zod schemas 🤔

@Siegrift
Copy link
Collaborator Author

Siegrift commented Oct 4, 2023

I guess the loadConfig function could be something to have in the common repo eventually (it would only need to be changed to accept the config zod schema as an input), along with some of the common zod schemas 🤔

Yeah. I will be working on that starting today. One thing to note is that composing the schema may not be 100% compatible if different zod version is used (which can be the case once the schemas are in commons). This sometimes happened with OIS. The solution was to use the same Zod schema version, but it was a bit annoying... (still better then copypasting it each time though imo).

@Siegrift Siegrift merged commit 3f33084 into main Oct 4, 2023
@Siegrift Siegrift deleted the chain-integration branch November 22, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement chain integration without DapiDataRegistry
2 participants