This repository was archived by the owner on Jul 9, 2024. It is now read-only.
Refactor data feed updates #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acenolaza
approved these changes
Aug 26, 2022
src/update-data-feeds.ts
Outdated
| @@ -39,6 +39,8 @@ type BeaconSetBeaconValue = { | |||
| value: ethers.BigNumber; | |||
| }; | |||
|
|
|||
| type DataFeedType = 'beacon' | 'beaconSet'; | |||
There was a problem hiding this comment.
It might be better to use an enum to avoid having to deal with letter casing
amarthadan
force-pushed
the
refactor-update-data-feeds
branch
from
0575bb8 to
fb46072
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #167
Review preferably commit by commit. I'm open to removing any of the commits if you find any of the refactors not that useful.