Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

Expand data fetching to include beacons from the beaconSets section #165 #175

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Expand data fetching to include beacons from the beaconSets section #165 #175

merged 1 commit into from
Jul 26, 2022

Conversation

acenolaza
Copy link
Contributor

Closes #165

@acenolaza acenolaza self-assigned this Jul 25, 2022
aquarat
aquarat approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :)
De-duplication of beacon ID update assessment is elegant.

@acenolaza
Copy link
Contributor Author

Looks great to me :) De-duplication of beacon ID update assessment is elegant.

I have to give the credit to @Siegrift for that since I started by using Array.from(new Set([...beconIds, ...beaconSetsBeaconIds])) but then I saw he was using lodash/uniq on another file :)

Siegrift
Siegrift approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Btw. you could have based this PR onto #174

@acenolaza
Copy link
Contributor Author

+1 LGTM

Btw. you could have based this PR onto #174

I did 😕 but I might have selected the wrong base branch when creating the PR

@acenolaza acenolaza force-pushed the 165-fetch-data-for-beacons-in-beaconSets branch from 5217e55 to cbf9a59 Compare July 26, 2022 14:41
@acenolaza acenolaza force-pushed the 165-fetch-data-for-beacons-in-beaconSets branch from cbf9a59 to 764bc10 Compare July 26, 2022 18:53
@acenolaza acenolaza merged commit 0f2c1e3 into main Jul 26, 2022
@acenolaza acenolaza deleted the 165-fetch-data-for-beacons-in-beaconSets branch July 26, 2022 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aquarat aquarat aquarat approved these changes

@Siegrift Siegrift Siegrift approved these changes

@amarthadan amarthadan Awaiting requested review from amarthadan

@vponline vponline Awaiting requested review from vponline

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand data fetching to include beacons from the beaconSets section
3 participants
@acenolaza @aquarat @Siegrift