Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

Prepare config format & validation for beaconSets section #163

Closed
amarthadan opened this issue Jul 17, 2022 · 2 comments · Fixed by #173
Closed

Prepare config format & validation for beaconSets section #163

amarthadan opened this issue Jul 17, 2022 · 2 comments · Fixed by #173

Comments

@amarthadan
Copy link
Contributor

amarthadan commented Jul 17, 2022

This section describes what beacons (array elements are beacon IDs) belong to a specific beacon set (the object keys are beacon set IDs):

"beaconSets": {
  "0x924b5d4cb3ec6366ae4302a1ca6aec035594ea3ea48a102d160b50b0c43ebfb5": [
    "0x924b5d4cb3ec6366ae4302a1ca6aec035594ea3ea48a102d160b50b0c43ebfb5",
    "0x924b5d4cb3ec6366ae4302a1ca6aec035594ea3ea48a102d160b50b0c43ebfb6"
  ]
},

In the validation, we need to make sure that every beacon listed has its counterpart in the beacons section.

@bbenligiray
Copy link
Member

What if 0x924b5d4cb3ec6366ae4302a1ca6aec035594ea3ea48a102d160b50b0c43ebfb5 is also listed under beacons, would it be fetched twice, independently?
It feels like my answer to the first question here was wrong and we should always list all Beacons that are being updated (individually or as a set) under beacons.

@amarthadan
Copy link
Contributor Author

Issue description updated based on the Slack discussion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants