-
Notifications
You must be signed in to change notification settings - Fork 155
[MINOR] build: Update create-package.sh #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM, thanks for the fix. The CI is still failed, maybe you need to re-trigger that. |
advancedxy
approved these changes
Aug 7, 2024
Merging this, thanks @jerqi |
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 9, 2024
### What changes were proposed in this pull request? Update create-package.sh ### Why are the changes needed? I renamed `DISCLAIMER-WIP` to `DISCLAIMER`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need.
zhengchenyu
added a commit
to zhengchenyu/uniffle
that referenced
this pull request
Aug 9, 2024
This reverts commit 9def891.
zhengchenyu
added a commit
that referenced
this pull request
Aug 19, 2024
This reverts commit 9def891.
maobaolong
pushed a commit
to maobaolong/incubator-uniffle
that referenced
this pull request
Sep 24, 2024
### What changes were proposed in this pull request? Update create-package.sh ### Why are the changes needed? I renamed `DISCLAIMER-WIP` to `DISCLAIMER`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need. (cherry picked from commit 5ce4605)
jerqi
added a commit
that referenced
this pull request
Dec 23, 2024
### What changes were proposed in this pull request? Update create-package.sh ### Why are the changes needed? I renamed `DISCLAIMER-WIP` to `DISCLAIMER`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update create-package.sh
Why are the changes needed?
I renamed
DISCLAIMER-WIP
toDISCLAIMER
.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.