Fix tag empty error and disorder timestamp. #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinLeeo
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #489 +/- ##
========================================
Coverage 65.48% 65.48%
========================================
Files 565 565
Lines 33040 33047 +7
Branches 4603 4606 +3
========================================
+ Hits 21636 21642 +6
Misses 10762 10762
- Partials 642 643 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
May 12, 2025
Comment on lines
201
to
213
| for (int32_t pos : id_column_context.pos_in_result_) { | ||
| common::String device_id( | ||
| device_query_task_->get_device_id()->get_segments().at( | ||
| id_column_context.pos_in_device_id_)); | ||
| common::String device_id; | ||
| if (device_query_task_->get_device_id()->segment_num() <= | ||
| id_column_context.pos_in_device_id_) { | ||
| device_id = common::String(""); | ||
| } else { | ||
| device_id = common::String( | ||
| device_query_task_->get_device_id()->get_segments().at( | ||
| id_column_context.pos_in_device_id_)); | ||
| } | ||
| if (RET_FAIL(col_appenders_[pos + 1]->fill( | ||
| (char*)&device_id, sizeof(device_id), | ||
| current_block_->get_row_count()))) { |
There was a problem hiding this comment.
We should distinguish null from empty string.
("table1", null, "tag1") is different from ("table1", "", "tag1")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.