Skip to content

feat(helm): add extraConfigsFiles support for file-based ConfigMap injection #34063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LeeDongon
Copy link

SUMMARY

Adds extraConfigsFiles support to the Superset Helm Chart, enabling users to inject ConfigMap values using file-based configurations.

TESTING INSTRUCTIONS

Place a YAML file (e.g., files/user_rbac.yml) under your Helm chart.

In values.yaml, add:

extraConfigsFiles:
  user_rbac.yml: files/user_rbac.yml
extraConfigMountPath: "/app/configs"

### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [x] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@dosubot dosubot bot added the deploy:helm label Jul 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me but would love confirmation from @villebro or @dpgaspar as our maintainers closer to helm

@mistercrunch
Copy link
Member

mistercrunch commented Jul 4, 2025

Oh also might need to bump the chart's version number? I tried to look for docs around how to approach changing the helm chart but couldn't find anything. @villebro wondering if you write a short entry for the Contributing portion of the docs so we can refer people to it (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants