fix(translations): Fix translation of time-related strings like "7 seconds ago", "a minute ago", etc #34051

PolinaFam · 2025-07-03T10:18:30Z

SUMMARY

Issue Description
Switching the language to English does not fully apply, leaving some time-related strings in the previous language. All untranslated time-related strings are created by dayjs and humanize libraries.

Solution
Fix dayjs strings: move all dayjs locale imports from useLocale.ts hook to preamble.ts. Without them, dayjs.locale() calls have no effect, leaving dates/times in the default language.
Fix humanized strings: translate changed_on_humanized and created_on_humanized using current locale from flask_babel.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Add next lines to config file:

BABEL_DEFAULT_LOCALE` = "ru"
LANGUAGES = {
  "ru": {"flag": "ru", "name": "Русский"},
  "en": {"flag": "us", "name": "English"}
}

Start the application.
Switch the interface language to English.
Verify the translations.

ADDITIONAL INFORMATION

Has associated issue: Fixes Translation of time passed #33630, Superset seems to be ignoring few frontend translations #7792
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Inefficient Static Locale Imports ▹ view	🧠 Not in scope
	Hardcoded default locale ▹ view	🧠 Not in scope
	Redundant Time Formatting Logic ▹ view	🧠 Not in standard
	Inefficient Repeated Locale Switching ▹ view	🧠 Not in standard

Files scanned

File Path	Reviewed
superset-frontend/src/hooks/useLocale.ts	✅
superset-frontend/src/preamble.ts	✅
superset/models/helpers.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

superset-frontend/src/preamble.ts

+import 'dayjs/locale/en';
+import 'dayjs/locale/fr';
+import 'dayjs/locale/es';
+import 'dayjs/locale/it';
+import 'dayjs/locale/zh-cn';
+import 'dayjs/locale/ja';
+import 'dayjs/locale/de';
+import 'dayjs/locale/pt';
+import 'dayjs/locale/pt-br';
+import 'dayjs/locale/ru';
+import 'dayjs/locale/ko';
+import 'dayjs/locale/sk';
+import 'dayjs/locale/sl';
+import 'dayjs/locale/nl';


superset/models/helpers.py

    def changed_on_humanized(self) -> str:
+        locale = str(get_locale() or 'en')
+        try:
+            humanize.i18n.activate(locale)
+            result = humanize.naturaltime(datetime.now() - self.changed_on)
+            humanize.i18n.deactivate()
+            return result


superset/models/helpers.py

@@ -546,10 +546,28 @@ def changed_on_utc(self) -> str:

    @property
    def changed_on_humanized(self) -> str:
+        locale = str(get_locale() or 'en')


superset/models/helpers.py

    def changed_on_humanized(self) -> str:
+        locale = str(get_locale() or 'en')
+        try:
+            humanize.i18n.activate(locale)
+            result = humanize.naturaltime(datetime.now() - self.changed_on)
+            humanize.i18n.deactivate()
+            return result
+        except:
+            pass
+        # Fallback to English
        return humanize.naturaltime(datetime.now() - self.changed_on)

    @property
    def created_on_humanized(self) -> str:
+        locale = str(get_locale() or 'en')
+        try:
+            humanize.i18n.activate(locale)
+            result = humanize.naturaltime(datetime.now() - self.created_on)
+            humanize.i18n.deactivate()
+            return result
+        except:
+            pass
+        # Fallback to English
        return humanize.naturaltime(datetime.now() - self.created_on)


mistercrunch · 2025-07-04T19:43:20Z

superset/models/helpers.py

+            result = humanize.naturaltime(datetime.now() - self.changed_on)
+            humanize.i18n.deactivate()
+            return result
+        except:


Are we expecting this to fail? In what cases? Not sure if swallowing anything/everything is best here, often if we know something might fail we'd try to swallow just that one particular exception, and maybe logging.exception(e) to handle the rest of the pessimisticism, so it's unexcpected, handled - but logged somewhere.

Otherwise you may just never know that say your particular locale isn't handled by humanize.

codecov · 2025-07-05T09:04:52Z

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.71%. Comparing base (23b1fe3) to head (d3c4cac).
Report is 40 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/models/helpers.py	76.47%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #34051       +/-   ##
===========================================
+ Coverage        0   72.71%   +72.71%     
===========================================
  Files           0      559      +559     
  Lines           0    40442    +40442     
  Branches        0     4247     +4247     
===========================================
+ Hits            0    29408    +29408     
- Misses          0     9937     +9937     
- Partials        0     1097     +1097

Flag	Coverage Δ
postgres	`71.92% <76.47%> (?)`
presto	`50.95% <41.17%> (?)`
python	`72.68% <76.47%> (?)`
sqlite	`71.44% <76.47%> (?)`
unit	`100.00% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Polina Fam added 2 commits July 3, 2025 12:09

fix: translate humanize string with current locale

2c4d813

fix: translate dayjs string with current locale

d3c4cac

pull-request-size bot added the size/M label Jul 3, 2025

korbit-ai bot reviewed Jul 3, 2025

View reviewed changes

dosubot bot added the i18n:general Related to translations label Jul 3, 2025

mistercrunch reviewed Jul 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(translations): Fix translation of time-related strings like "7 seconds ago", "a minute ago", etc #34051

fix(translations): Fix translation of time-related strings like "7 seconds ago", "a minute ago", etc #34051

PolinaFam commented Jul 3, 2025

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

mistercrunch Jul 4, 2025

Uh oh!

codecov bot commented Jul 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

fix(translations): Fix translation of time-related strings like "7 seconds ago", "a minute ago", etc #34051

Are you sure you want to change the base?

fix(translations): Fix translation of time-related strings like "7 seconds ago", "a minute ago", etc #34051

Conversation

PolinaFam commented Jul 3, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

mistercrunch Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

korbit-ai bot left a comment •

edited

Loading

codecov bot commented Jul 5, 2025 •

edited

Loading