Skip to content

fix(i18n): update Russian translation #34005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

PolinaFam
Copy link
Contributor

SUMMARY

This PR updates language files, as described in the documentation. Manual changes were made only in file with Russian localization:

  • Fixed typos and written language style issues
  • Added missing translations
  • Cleaned up fuzzy strings
  • Fixed translations causing layout breaks (marked with comments)
  • Marked non-translatable strings with "Не переводить" comments

I made up the following glossary:

alert - оповещение
bins - бины
chart - диаграмма
cluster - кластер
column - столбец
cross-filter - кросс-фильтр
cross-filtering - кросс-фильтрация
dashboard - дашборд
dataset - датасет
label - метка
metric - мера
option (булевая) - флаг
outlier - выброс
range - диапазон
redirect - перенаправление
report - отчет
spread - разброс
tag - тег
threshold - порог
tooltip - всплывающая подсказка
zoom - масштабирование

This is part of ongoing efforts to improve Superset’s Russian localization. Hope these improvements will enhance the user experience for Russian-speaking users.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Jul 1, 2025

Korbit doesn't automatically review large (3000+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

@dosubot dosubot bot added the i18n:russian Translation related to Russian language label Jul 1, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sadpandajoe sadpandajoe requested a review from rusackas July 2, 2025 23:37
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.99%. Comparing base (7d0fabe) to head (fa17e45).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #34005       +/-   ##
===========================================
+ Coverage        0   72.99%   +72.99%     
===========================================
  Files           0      559      +559     
  Lines           0    40517    +40517     
  Branches        0     4267     +4267     
===========================================
+ Hits            0    29574    +29574     
- Misses          0     9834     +9834     
- Partials        0     1109     +1109     
Flag Coverage Δ
hive 47.15% <ø> (?)
mysql 71.98% <ø> (?)
postgres 72.03% <ø> (?)
presto 50.90% <ø> (?)
python 72.95% <ø> (?)
sqlite 71.57% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +858 to +864
# Если переводить дословно "Добавить разделитель", то поедет верстка
msgid "Add Divider"
msgstr "Разделитель"

#, fuzzy
# Если переводить дословно "Добавить фильтр", то поедет верстка
msgid "Add Filter"
msgstr "Добавить фильтр"
msgstr "Фильтр"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment here says "If you translate literally, then markup breaks" (because of long phrase). I think we should fix markup instead of adjusting translations.

@rusackas @michael-s-molina @mistercrunch what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes, though breaking long strings into smaller ones will disconnect all existing translations in other language, forcing to retranslate the long strings. So some tradeoffs here.

A while back I worked on an AI-powered babel-based translation framework for .po files, but never finished it. Ideally we start using something like that soon. I haven't looked to see if other frameworks have popped up over the past few months, but would be great to set this thing in motion and automate filling all missing translations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would be better to fix markup but not in this PR. These changes are supposed to fill empty translations and fix fuzzy strings for Russian language. If you don't mind I would create another PR with markup fixes. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me personally

@Quatters
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:russian Translation related to Russian language size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants