-
Notifications
You must be signed in to change notification settings - Fork 15.3k
fix(i18n): update Russian translation #34005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34005 +/- ##
===========================================
+ Coverage 0 72.99% +72.99%
===========================================
Files 0 559 +559
Lines 0 40517 +40517
Branches 0 4267 +4267
===========================================
+ Hits 0 29574 +29574
- Misses 0 9834 +9834
- Partials 0 1109 +1109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Если переводить дословно "Добавить разделитель", то поедет верстка | ||
msgid "Add Divider" | ||
msgstr "Разделитель" | ||
|
||
#, fuzzy | ||
# Если переводить дословно "Добавить фильтр", то поедет верстка | ||
msgid "Add Filter" | ||
msgstr "Добавить фильтр" | ||
msgstr "Фильтр" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment here says "If you translate literally, then markup breaks" (because of long phrase). I think we should fix markup instead of adjusting translations.
@rusackas @michael-s-molina @mistercrunch what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably yes, though breaking long strings into smaller ones will disconnect all existing translations in other language, forcing to retranslate the long strings. So some tradeoffs here.
A while back I worked on an AI-powered babel-based translation framework for .po
files, but never finished it. Ideally we start using something like that soon. I haven't looked to see if other frameworks have popped up over the past few months, but would be great to set this thing in motion and automate filling all missing translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it would be better to fix markup but not in this PR. These changes are supposed to fill empty translations and fix fuzzy strings for Russian language. If you don't mind I would create another PR with markup fixes. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me personally
# Conflicts: # superset/translations/ja/LC_MESSAGES/messages.po
LGTM |
SUMMARY
This PR updates language files, as described in the documentation. Manual changes were made only in file with Russian localization:
I made up the following glossary:
This is part of ongoing efforts to improve Superset’s Russian localization. Hope these improvements will enhance the user experience for Russian-speaking users.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION