Skip to content

fix(i18n): Update Japanese translations #33974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aikawa-ohno
Copy link
Contributor

The Japanese translation has been updated.

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:japanese Translation related to Japanese language labels Jun 30, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (2e9939b) to head (f4a0460).
Report is 69 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #33974       +/-   ##
===========================================
+ Coverage        0   72.88%   +72.88%     
===========================================
  Files           0      559      +559     
  Lines           0    40425    +40425     
  Branches        0     4247     +4247     
===========================================
+ Hits            0    29465    +29465     
- Misses          0     9859     +9859     
- Partials        0     1101     +1101     
Flag Coverage Δ
hive 47.20% <ø> (?)
mysql 71.87% <ø> (?)
postgres 71.93% <ø> (?)
presto 50.96% <ø> (?)
python 72.85% <ø> (?)
sqlite 71.45% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe sadpandajoe requested a review from rusackas June 30, 2025 17:29
@aikawa-ohno aikawa-ohno changed the title Update Japanese translations fix(i18n):Update Japanese translations Jul 3, 2025
@aikawa-ohno aikawa-ohno changed the title fix(i18n):Update Japanese translations fix(i18n): Update Japanese translations Jul 3, 2025
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blindly approving since I don't speak japanese, but I'm assuming this is a significant step forward.

Now I'm thinking it'd be good to keep a list of github username that we can call upon for each language, so we can tag them for reviews.

In the meantime we'll generally have to assume that most updates are incrementally better than the previous state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:japanese Translation related to Japanese language i18n Namespace | Anything related to localization size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants