Skip to content

feat(Table): Add infrastructure to override time shifts #33947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

msyavuz
Copy link
Member

@msyavuz msyavuz commented Jun 27, 2025

SUMMARY

Add infrastructure to override time shifts in form data for table charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Jun 27, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@msyavuz msyavuz marked this pull request as ready for review June 30, 2025 12:50
@dosubot dosubot bot added the viz:charts:table Related to the Table chart label Jun 30, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Functionality Time Compare Override Obliterates Existing Time Shifts ▹ view 🧠 Not in scope
Files scanned
File Path Reviewed
superset-frontend/packages/superset-ui-core/src/query/types/Time.ts
superset-frontend/packages/superset-ui-core/src/query/constants.ts
superset-frontend/packages/superset-ui-core/src/query/extractExtras.ts
superset-frontend/packages/superset-ui-core/src/query/types/QueryFormData.ts
superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts
superset-frontend/packages/superset-ui-core/src/query/types/Query.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@msyavuz msyavuz merged commit 09736ee into master Jun 30, 2025
55 checks passed
@msyavuz msyavuz deleted the msyavuz/feat/add-timeshift-overrides-capability branch June 30, 2025 13:32
ianngech pushed a commit to Pesapal-Ltd/superset that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants